Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RHINENG-13682): Update to remove All systems chip #325

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

johnsonm325
Copy link
Collaborator

To test:

  • Go to the Available tab
  • Click Select systems on a task
  • Use the eligibility filter

Test by removing the Eligible systems chip. It should remove the chip and apply All systems filter with no chip. Before, we swapped between the All systems and Eligible systems chips.

@johnsonm325 johnsonm325 requested a review from a team as a code owner January 14, 2025 22:54
@gkarat gkarat added the bug Something isn't working label Jan 17, 2025
Copy link
Contributor

@gkarat gkarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @johnsonm325

To test:

- Go to the Available tab
- Click Select systems on a task
- Use the eligibility filter

Test by removing the Eligible systems chip. It should remove the chip and apply All systems filter with no chip. Before, we swapped between the All systems and Eligible systems chips.
@johnsonm325 johnsonm325 merged commit 7059052 into RedHatInsights:master Jan 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants